Skip to content

k8s log acquisition datasource #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sabban wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

k8s log acquisition datasource #4221

sabban wants to merge 31 commits into from
+507 −5

Conversation

@sabban
Copy link
Contributor

@sabban sabban commented Jan 22, 2026

k8s log acquisition datasource

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

@sabban: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

@sabban: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@sabban
Copy link
Contributor Author

sabban commented Jan 22, 2026

/kind feature
/area agent

@sabban sabban changed the title k8s log acquisition datasource [wip] k8s log acquisition datasource Jan 22, 2026
@sabban sabban marked this pull request as draft January 22, 2026 13:21
@sabban sabban changed the title [wip] k8s log acquisition datasource k8s log acquisition datasource Jan 22, 2026
@codecov
Copy link

codecov bot commented Feb 1, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 1.75439% with 168 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.37%. Comparing base (1df2c55) to head (e5bd9b4).

Files with missing lines Patch % Lines
pkg/acquisition/modules/kubernetes/run.go 0.00% 107 Missing ⚠️
pkg/acquisition/modules/kubernetes/config.go 0.00% 30 Missing ⚠️
pkg/acquisition/modules/kubernetes/utils.go 0.00% 15 Missing ⚠️
pkg/acquisition/modules/kubernetes/source.go 0.00% 8 Missing ⚠️
pkg/acquisition/modules/kubernetes/metrics.go 0.00% 6 Missing ⚠️
pkg/acquisition/modules/kubernetes/init.go 50.00% 0 Missing and 1 partial ⚠️
pkg/database/flush.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1df2c55) and HEAD (e5bd9b4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1df2c55) HEAD (e5bd9b4)
unit-linux 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4221      +/-   ##
==========================================
- Coverage   63.11%   57.37%   -5.75%     
==========================================
  Files         473      480       +7     
  Lines       33466    33637     +171     
==========================================
- Hits        21123    19298    -1825     
- Misses      10222    12252    +2030     
+ Partials     2121     2087      -34
Flag Coverage Δ
bats 46.31% <1.75%> (-0.27%) ⬇️
unit-linux ?
unit-windows 24.32% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc
Copy link
Contributor

mmetc commented Feb 5, 2026

quick 2¢, I didn't follow the logic yet:

  • the package is not imported from pkg/acquisition
  • name of the package/datasource is way too verbose for comfort
  • log.Fatal should just return errors
  • vestigial presence of tomb
  • there is an empty .keep file
  • references to DockerAcquisition, DockerDatasource
  • does one shot acquisition make sense for this DS?
  • the schema file should go in pkg/acquisition/schemas/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/agent kind/feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sabban @mmetc